Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add some restrictions in load_all_files_under_paths #1791

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Dec 17, 2024

Add some restrictions in load_all_files_under_paths to prevent performance issues

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

@He1pa He1pa force-pushed the restrictions_on_load_all_files_under_paths branch from 9db92be to 7f8dc14 Compare December 17, 2024 07:43
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12368526304

Details

  • 22 of 27 (81.48%) changed or added relevant lines in 1 file are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 70.684%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/parser/src/lib.rs 22 27 81.48%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/resolver/mod.rs 1 99.19%
kclvm/tools/src/LSP/src/request.rs 2 66.14%
kclvm/tools/src/LSP/src/dispatcher.rs 12 69.05%
Totals Coverage Status
Change from base Build 12367284350: -0.02%
Covered Lines: 52795
Relevant Lines: 74692

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit bc74f86 into main Dec 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants